Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OPRF root step to compact #830

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Add OPRF root step to compact #830

merged 3 commits into from
Nov 3, 2023

Conversation

akoshelev
Copy link
Collaborator

was getting an error running OPRF IPA with compact steps enabled

cannot narrow from the invalid step oprf_ipa
stack trace:

there is still another issue that I don't know how to fix yet

thread 'tokio-runtime-worker' panicked at src/protocol/prf_sharding/mod.rs:219:10:
Invalid state transition: 8815 -> row3

was getting an error running OPRF IPA with compact steps enabled

```
cannot narrow from the invalid step oprf_ipa
stack trace:
```
@akoshelev akoshelev requested a review from taikiy November 2, 2023 19:05
Copy link
Contributor

@taikiy taikiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes.

@akoshelev akoshelev merged commit c9f3d58 into main Nov 3, 2023
10 checks passed
@akoshelev akoshelev deleted the oprf-compact-step branch November 3, 2023 20:24
taikiy pushed a commit to taikiy/ipa that referenced this pull request Nov 6, 2023
* Add OPRF root step to compact

was getting an error running OPRF IPA with compact steps enabled

```
cannot narrow from the invalid step oprf_ipa
stack trace:
```

* Fix a compile bug inside compact map

* Reorder constants and fix the step number for OPRF
@taikiy
Copy link
Contributor

taikiy commented Nov 6, 2023

there is still another issue that I don't know how to fix yet

thread 'tokio-runtime-worker' panicked at src/protocol/prf_sharding/mod.rs:219:10:
Invalid state transition: 8815 -> row3

#834 fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants